Skip to content

Add tag / version table to Readme #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Add tag / version table to Readme #111

merged 2 commits into from
Dec 1, 2017

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Nov 29, 2017

@dougbu
Copy link
Contributor Author

dougbu commented Nov 29, 2017

@Eilon do you want the package versions to link to the primary packages (Microsoft.AspNet.Mvc, Microsoft.AspNet.WebApi, Microsoft.AspNet.WebPages) on https://nuget.org?

README.md Outdated
[v2.1](https://github.com/aspnet/AspNetWebStack/tree/v2.1)||ASP.NET and Web Tools 2012.2, VS 2012 Update 2 (not on http://nuget.org)|v4 2012.2 Update RTM|v1 2012.2 Update RTM|v2 2012.2 Update RTM
[v3.0.2](https://github.com/aspnet/AspNetWebStack/tree/v3.0.2)|[v3-rtm](https://github.com/aspnet/AspNetWebStack/tree/v3-rtm)|ASP.NET MVC 5.0.2|5.0.2|5.0.1|3.0.1
[v3.1.3](https://github.com/aspnet/AspNetWebStack/tree/v3.1.3)|[v3.1-rtm](https://github.com/aspnet/AspNetWebStack/tree/v3.1-rtm)|ASP.NET MVC 5.1.3|5.1.3|5.1.2|3.1.2
[v3.2.3](https://github.com/aspnet/AspNetWebStack/tree/v3.2.3)||ASP.NET MVC 5.2.3 / Web API 2.2.3 / Web Pages 3.2.3 |5.2.3|5.2.3|3.2.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this row contained more product names than the ones above. Want something similar there? Or, perhaps do this only on the first row?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is odd so I wouldn't have this line have a different structure than other lines. But, I also forgot that we have a mismatch for Web API between the product version and package version. Perhaps for the Web API column it should be titled Web API package version (product version), and then in each row do something like 5.2.3 (2.2.3).

README.md Outdated
[v2.1](https://github.com/aspnet/AspNetWebStack/tree/v2.1)||ASP.NET and Web Tools 2012.2, VS 2012 Update 2 (not on http://nuget.org)|v4 2012.2 Update RTM|v1 2012.2 Update RTM|v2 2012.2 Update RTM
[v3.0.2](https://github.com/aspnet/AspNetWebStack/tree/v3.0.2)|[v3-rtm](https://github.com/aspnet/AspNetWebStack/tree/v3-rtm)|ASP.NET MVC 5.0.2|5.0.2|5.0.1|3.0.1
[v3.1.3](https://github.com/aspnet/AspNetWebStack/tree/v3.1.3)|[v3.1-rtm](https://github.com/aspnet/AspNetWebStack/tree/v3.1-rtm)|ASP.NET MVC 5.1.3|5.1.3|5.1.2|3.1.2
[v3.2.3](https://github.com/aspnet/AspNetWebStack/tree/v3.2.3)||ASP.NET MVC 5.2.3 / Web API 2.2.3 / Web Pages 3.2.3 |5.2.3|5.2.3|3.2.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is odd so I wouldn't have this line have a different structure than other lines. But, I also forgot that we have a mismatch for Web API between the product version and package version. Perhaps for the Web API column it should be titled Web API package version (product version), and then in each row do something like 5.2.3 (2.2.3).

@dougbu
Copy link
Contributor Author

dougbu commented Nov 30, 2017

🆙📅

Git tag|Git branch|Other products|MVC package versions|Web API package (product) versions|Web Pages package versions
--------|--------------|------------|------------|------------|------------
[v2.0.4](https://github.com/aspnet/AspNetWebStack/tree/v2.0.4)|[v2.0-rtm](https://github.com/aspnet/AspNetWebStack/tree/v2.0-rtm)||4.0.40804|4.0.30506|2.0.30506
[v2.1](https://github.com/aspnet/AspNetWebStack/tree/v2.1)||ASP.NET and Web Tools 2012.2, VS 2012 Update 2 (not on http://nuget.org)|v4 2012.2 Update RTM|v1 2012.2 Update RTM|v2 2012.2 Update RTM
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not thrilled with this row or the "Other products" column in general. We need to say something about the v2.1 tag but I'm not sure details of the versions buried in WTE and VS matter. Thinking about removing everything in the 3 "package versions" columns and moving the "Other products" column to the end, perhaps naming it "Notes". Thoughts?


Git tag|Git branch|Other products|MVC package versions|Web API package (product) versions|Web Pages package versions
--------|--------------|------------|------------|------------|------------
[v2.0.4](https://github.com/aspnet/AspNetWebStack/tree/v2.0.4)|[v2.0-rtm](https://github.com/aspnet/AspNetWebStack/tree/v2.0-rtm)||4.0.40804|4.0.30506|2.0.30506
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The details pages in the NuGet gallery don't start distinguishing package and product versions for Web API until v5.0. Add "(2.0.3)" anyhow?

Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is fine. It's a big improvement over what we had before.

@dougbu dougbu merged commit 7dad200 into master Dec 1, 2017
@dougbu dougbu deleted the dougbu/patch.readme branch December 1, 2017 01:18
@dougbu
Copy link
Contributor Author

dougbu commented Dec 1, 2017

7dad200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants